Move to standalone components #3155
Conversation
✅ Deploy Preview for carbon-components-angular ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-angular-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
| exports: [ | ||
| Accordion, | ||
| AccordionItem | ||
| ], | ||
| imports: [ | ||
| CommonModule, | ||
| IconModule | ||
| IconModule, |
There was a problem hiding this comment.
This is amazing work, thank you for this!
Do we still need modules? I thought we wouldn't need to keep the Modules once we go standalone or is this for backwards compatibility?
There was a problem hiding this comment.
Yes, I wanted to keep the modules for backwards compatibility since angular 18 still allows the functionality and I didn’t want to break my own apps by upgrading.
in the end we don’t need them anymore and I/we/soneone could look into the angular migrations to ease the transition from modules to standalone.
|
@Akshat55 what is your stance or policy regarding backwards compatibility on the next branch? There are a lot of interesting features in current angular releases, also with regards to signals and zoneless. Would it be okay to make the next branch angular 20+ and drop backwards compatibility? The version numbers here (v5, ...) does not align with carbon upstream (which is at 11) nor with angular (20), so if you have no internal policy of supporting all versions of angular, maybe a clear cut and upgrade with the next branch would do it as well? |
|
Hey @georgmu, we need backwards compatibility, because many teams have massive applications and are slow to upgrade to latest angular versions + features. However, this should be taken care of with v5 - just means we will have to support v5 until Carbon 12 is released or have enough teams migrated to use v6. I would be okay with Angular 20 as next branch, it would have to be another PR though. This PR will take some time to review/merge - I want to have some teams test it possible. I'll also be testing locally via linking. |
Updates all components to standalone components
It got a bit big but I've tried to move all components to standalone components. My test-setup is a bit confused with the changes but it works with the tests and storybook.
Changelog
Changed
I'm on vacation for the next two weeks but will look into this from time to time.